Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

noresm2_3_develop : Introduction of possibility to run with full atmospheric chemistry #149

Merged
merged 18 commits into from
Sep 19, 2024
Merged

noresm2_3_develop : Introduction of possibility to run with full atmospheric chemistry #149

merged 18 commits into from
Sep 19, 2024

Conversation

DirkOlivie
Copy link

@DirkOlivie DirkOlivie commented May 30, 2024 •
edited by gold2718
Loading

Summary: Introduction of the ability to run with more complex atmospheric gas-phase chemistry.

Contributors: Dirk Olivié

Reviewers: Steve Goldhaber

Purpose of changes: #100 Add trop+strat chemistry scheme. The new scheme is a combination of the aerosols from OSLO_AERO and the gas-phase species from the TS1 chemistry (pp_trop_strat_mam4_vbs).

Github PR URL:

Changes made to build system: None

Changes made to the namelist:

  1. the namelist used by the new compsets contains elements from the standard aerosol-only NorESM namelist, but some external forcings have been removed as not used anymore (ozone climatology, ozone climatology, volcanic stratospheric AOD).
  2. New things are : more emissions files are used, more GHGs/ODSs are prescribed, and the lightning NOx scaling factor is now used.
  3. Concerning MEGAN fluxes from the land-model : more species are mapped into monoterpene (to make it more in line with CESM).
  4. 3D-chemical species are taken into account in the radiation

Changes to the defaults for the boundary datasets:

  1. there are additional emission files
  2. some climatologies are not used anymore (ozone, oxidants)

Substantial timing or memory changes: an N1850_f19_tn14 simulation on 1024 CPUs is much slower. The throughput is 8.67 simulated years/day (compared to 19.84 simulated years/day in aerosol-only version)

Detailed description of changes :
General files :
bld/build-namelist
bld/config_files/definition.xml [new chemical package "tropstrat_mam_oslo]
bld/configure
bld/namelist_files/use_cases/1850_cam6_noresm_tropstratchem.xml [4 new use cases]
bld/namelist_files/use_cases/hist_cam6_noresm_tropstratchem.xml
bld/namelist_files/use_cases/ssp370_cam6_noresm_tropstratchem.xml
bld/namelist_files/use_cases/ssp585_cam6_noresm_tropstratchem.xml
cime_config/config_component.xml
cime_config/config_compsets.xml
cime_config/testdefs/testlist_cam.xml

Files in specific chemistry directory pp_tropstrat_mam_oslo (generated by chemical preprocessor):
src/chemistry/pp_tropstrat_mam_oslo/chem_mech.doc
src/chemistry/pp_tropstrat_mam_oslo/chem_mech.in
src/chemistry/pp_tropstrat_mam_oslo/chem_mods.F90
src/chemistry/pp_tropstrat_mam_oslo/m_rxt_id.F90
src/chemistry/pp_tropstrat_mam_oslo/m_spc_id.F90
src/chemistry/pp_tropstrat_mam_oslo/mo_adjrxt.F90
src/chemistry/pp_tropstrat_mam_oslo/mo_exp_sol.F90
src/chemistry/pp_tropstrat_mam_oslo/mo_imp_sol.F90
src/chemistry/pp_tropstrat_mam_oslo/mo_indprd.F90
src/chemistry/pp_tropstrat_mam_oslo/mo_lin_matrix.F90
src/chemistry/pp_tropstrat_mam_oslo/mo_lu_factor.F90
src/chemistry/pp_tropstrat_mam_oslo/mo_lu_solve.F90
src/chemistry/pp_tropstrat_mam_oslo/mo_nln_matrix.F90
src/chemistry/pp_tropstrat_mam_oslo/mo_phtadj.F90
src/chemistry/pp_tropstrat_mam_oslo/mo_prod_loss.F90
src/chemistry/pp_tropstrat_mam_oslo/mo_rxt_rates_conv.F90
src/chemistry/pp_tropstrat_mam_oslo/mo_setrxt.F90
src/chemistry/pp_tropstrat_mam_oslo/mo_sim_dat.F90

Test run: ERP_D_Ln9.f19_f19_mtn14.NF1850norbc_tropstratchem.betzy_intel.cam-outfrq9s

closes #100

@DirkOlivie DirkOlivie added the Next release To be included in next release label May 30, 2024
@DirkOlivie DirkOlivie added this to the NorESM2.3 milestone May 30, 2024
@DirkOlivie DirkOlivie requested a review from gold2718 May 30, 2024 12:52
@DirkOlivie DirkOlivie self-assigned this May 30, 2024
@DirkOlivie DirkOlivie changed the title noresm2_3_fullchem : Introduction of possibility to run with full atmospheric chemistry noresm2_3_develop : Introduction of possibility to run with full atmospheric chemistry May 30, 2024
@TomasTorsvik TomasTorsvik mentioned this pull request May 30, 2024
Merged
gold2718
gold2718 requested changes May 30, 2024
View reviewed changes
Copy link

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly looks good but I have some questions and concerns.

cime_config/config_component.xml Outdated Show resolved Hide resolved
Externals_CAM.cfg Show resolved Hide resolved
bld/namelist_files/use_cases/1850_cam6_noresm_tropstratchem.xml Show resolved Hide resolved
bld/namelist_files/use_cases/1850_cam6_noresm_tropstratchem.xml Show resolved Hide resolved
bld/namelist_files/use_cases/1850_cam6_noresm_tropstratchem.xml Show resolved Hide resolved
bld/namelist_files/use_cases/hist_cam6_noresm_tropstratchem.xml Show resolved Hide resolved
bld/namelist_files/use_cases/ssp370_cam6_noresm_tropstratchem.xml Show resolved Hide resolved
bld/namelist_files/use_cases/ssp585_cam6_noresm_tropstratchem.xml Show resolved Hide resolved
bld/namelist_files/use_cases/ssp585_cam6_noresm_tropstratchem.xml Show resolved Hide resolved
bld/namelist_files/use_cases/ssp585_cam6_noresm_tropstratchem.xml Show resolved Hide resolved
@DirkOlivie
modified repo_url for OSLO_AERO in Externals_CAM.cfg : points to gith…
58805de 
…ub.com/DirkOlivie/OSLO_AERO (as long as OSLO_AERO PR is not accepted)
@gold2718 gold2718 requested review from mvertens and removed request for mvertens June 19, 2024 17:08
@DirkOlivie DirkOlivie requested a review from gold2718 September 17, 2024 10:09
gold2718
gold2718 requested changes Sep 17, 2024
View reviewed changes
Copy link

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the tag in Externals_CAM.cfg to be oslo_aero_2_3a2.

@DirkOlivie
Copy link
Author

Hi Steve (@gold2718), I have now updated the OSLO_AERO tag in Externals_CAM.cfg to oslo_aero2_3a2.

gold2718
gold2718 approved these changes Sep 17, 2024
View reviewed changes
Copy link

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@gold2718
Copy link

Are there any expected answer or namelist changes when not running the new chemistry scheme?

@DirkOlivie
Copy link
Author

Hi Steve (@gold2718), no there should not be any answer changes. I will try to look into it now and do some tests.

@DirkOlivie
Copy link
Author

Hi Steve (@gold2718),
I have now done two simulations for the N1850 compset and they gave identical results. The simulations are using :

  • my latest version of CAM and OSLO_AERO I had on Betzy, where the full-chemistry code was in
  • CAM (commit 3db5e69) and OSLO_AERO (commit 8b3e7dde) versions from before the full-chemistry code was merged in.
    Do these comparisons make sense, or did I do something wrong?

@gold2718
Copy link

I believe the OSLO_AERO commit should be tag = oslo_aero_2_3a1 which is NorESMhub/OSLO_AERO@1a03f8c
The CAM hash should be 3db5e69 .
It looks like your CAM commit is correct but your OSLO_AERO commit is different.

@DirkOlivie
Copy link
Author

Hi Steve (@gold2718), I have now checked out for OSLO_AERO the oslo_aero_2_3a1 tag. It differs in what I have in oslo_aero_depos.F90. The oslo_aero_2_3a1 tag does not have the lines :

! Increase scavenging efficiency for large soluble particles.
              if ((lphase==1).and.((mm==l_ss_a2).or.(mm==l_ss_a3).or.(mm==l_so4_a2))) then
                 sol_factic=1.0_r8
                 f_act_conv=1.0_r8
              end if

Might this be related to the difference?

@gold2718
Copy link

I think they could be. These lines come from a commit by @oyvindseland on 4. jul. as PR NorESMhub/OSLO_AERO#30

Commit message:
Increased in-cloud convective scavenging coefficient for sea-salt and aqueous phase produced sulfate

I need to make a new baseline with that change, thank you for finding this.

@gold2718 gold2718 merged commit 1450ca0 into NorESMhub:noresm2_3_develop Sep 19, 2024
@gold2718
Copy link

Good news, using the correct hash for OSLO_AERO, this PR is BFB for the previously existing tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gold2718 gold2718 gold2718 approved these changes

Assignees

@DirkOlivie DirkOlivie

Labels
Next release To be included in next release
Projects
NorESM Development
Status: Done
Milestone
NorESM2.3
Development

Successfully merging this pull request may close these issues.
2 participants
@DirkOlivie @gold2718